Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CAS sharpening to SMAA antialiasing. #2423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Muzz
Copy link
Contributor

@Muzz Muzz commented Apr 12, 2024

Just to explain motivation here.

I'm not a fan of the ghosting of TAA, but i think most people would say it looks best in static screenshots because of the sharpening inside of it.

So i wanted something that had that crispy look, but more configurable, so I wrote an implementation based on https://gpuopen.com/fidelityfx-cas/

Currently it's always on when SMAA is active, so you may want to throw in a switch for it.

give it a shot, i think it looks quite nice.

examples:

NO AA

image

TAA

image

SMAA with CAS

image

@Muzz
Copy link
Contributor Author

Muzz commented Apr 12, 2024

Not sure correct way to push a modified .flax shader because of the gitlab LFS btw, so i just pushed with no verify. I know it's a generated file so i think that's ok?

@Menotdan
Copy link
Contributor

Did you change something between the first two and the last screenshot? the dark cracks on the rock texture are significantly darker on the last image.

@Muzz
Copy link
Contributor Author

Muzz commented Apr 12, 2024

Did you change something between the first two and the last screenshot? the dark cracks on the rock texture are significantly darker on the last image.

That's just the results of a different sharpening algorithm. But you are welcome to test and check my working.

@mafiesto4 mafiesto4 added enhancement New feature or request graphics labels Apr 14, 2024
@mafiesto4 mafiesto4 added this to the 1.9 milestone Apr 14, 2024
@cNori
Copy link
Contributor

cNori commented Apr 14, 2024

Not sure correct way to push a modified .flax shader because of the gitlab LFS btw, so i just pushed with no verify. I know it's a generated file so i think that's ok?

if u need to submit modified .flax use the zip file for it

@mafiesto4
Copy link
Member

That's fine I'll update shader binary, shader source is only needed for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request graphics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants