Physics #2325
Open
Physics #2325
+2,286
−446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the PxJoint is not expecting to get scaled offset and is collapsing auto anchor also if A nd B actor is scaled it will snap the joint in to wrong location added SetTargetAnchor(const Transform& value)
cNori
changed the title
added a hack to prevent editing read only value from being edited
interesting case with colliders not being directly under rb, if the middle node('s) are rotated the collider was in wrong spot on back end
warning: 'OnDebugDraw' overrides a member function but is not marked 'override'
|
[to do] after a merge |
Tryibion
reviewed
May 22, 2024
Comment on lines
+369
to
+374
| #ifndef STRING2 | ||
| #define STRING2(x) #x | ||
| #define STRING(x) STRING2(x) | ||
| #endif | ||
| #pragma message ( __FILE__ "(" STRING(__LINE__) "):" "[Code Mantening] Remove Deprecated code") | ||
| #endif |
There was a problem hiding this comment.
yes there is a code inside the engine which is dedicated and expired
this is reminder to remove it
Comment on lines
+987
to
+1019
| #if 0 // data extractor | ||
|
|
||
| String out = String::Format(L"\n static Float3* points [{0}] = ", input.VertexCount); | ||
| out.Append('{'); | ||
| auto data = Array<Float3>(input.VertexData, input.VertexCount); | ||
| for (size_t i = 0; i < data.Count(); i++) | ||
| { | ||
| auto d = data[i]; | ||
| out.Append(String::Format(L"\tFloat3({0},{1},{2}),\n", d.X, d.Y, d.Z)); | ||
| } | ||
| out.Append(L"};"); | ||
| if (input.Is16bitIndexData) | ||
| { | ||
| auto data2 = Array<PxU16>((PxU16*)input.IndexData, input.IndexCount); | ||
| for (size_t i = 0; i < data2.Count(); i++) | ||
| { | ||
| auto d = data2[i]; | ||
| out.Append(String::Format(L"{0},\n",d)); | ||
| } | ||
| } | ||
| else | ||
| { | ||
| auto data2 = Array<PxU32>((PxU32*)input.IndexData, input.IndexCount); | ||
| for (size_t i = 0; i < data2.Count(); i++) | ||
| { | ||
| auto d = data2[i]; | ||
| out.Append(String::Format(L"{0},\n", d)); | ||
| } | ||
| } | ||
|
|
||
| LOG_STR(Info, out.ToString()); | ||
| #endif | ||
|
|
There was a problem hiding this comment.
I assume this is not used? does it need to stay? maybe for debug purposes?
There was a problem hiding this comment.
I assume this is not used?
yes it is unused
does it need to stay?
idk i used it to extract verts for breaking and just left it there
maybe for debug purposes?
if somfing break it will have use
note is striped from compilation any way
Comment on lines
+1
to
+25
| //template code for Deprecated code at some version | ||
| //----------------------------------------------------------------------------------- | ||
| // find and replace, legend / info | ||
| //----------------------------------------------------------------------------------- | ||
| // <depMAJOR> major version (0-...) | ||
| // <depMINOR> minor version (0-9) | ||
| //----------------------------------------------------------------------------------- | ||
| // requerd inclide | ||
| //----------------------------------------------------------------------------------- | ||
| // FlaxEngine.Gen.h | ||
| //----------------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| #pragma region Deprecated | ||
| #if (FLAXENGINE_VERSION_MAJOR != <depMAJOR> && (FLAXENGINE_VERSION_MINOR >= <depMINOR>)) | ||
| //<Deprecated code here> | ||
|
|
||
| #else | ||
| #ifndef STRING2 | ||
| #define STRING2(x) #x | ||
| #define STRING(x) STRING2(x) | ||
| #endif | ||
| #pragma message ( __FILE__ "(" STRING(__LINE__) "):" "[Code Mantening] Remove Deprecated code") | ||
| #endif | ||
| #pragma endregion |
There was a problem hiding this comment.
Guess Mafi can decide if he wants this.
throwed on backlog might be done some day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed joints including scale in calculations
the PxJoint is not expecting to get scaled offset and is collapsing auto anchor if A or B actor is scaled it will snap the joint in to wrong location
added SetTargetAnchor(const Transform& value)
Display Attached Colliders
when selecting rigid body it will show all attached colliders for the rigidbody.
can be enabled or disabled per object using DisplayAttachedColliders
Remove thick frame from box collider
when working with small enough collider it hard to set up good collisions for it
as a example
this got me on side quest to re doing coliders See: Better colliders
Better colliders
Colliders
Triggers
INFO:
Debug shapes need some more work put in to look better (there is some over draw and weird shading)
Tasks list