Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced cheeks with generic message found a way to hard crash the engine (Actor.cpp) #2319

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cNori
Copy link
Contributor

@cNori cNori commented Mar 14, 2024

Passing Quaterion
x 0
y 0
z 0
w -0
creates nan or inf in internal code and hard crashes the editor
cheeks has been replaced with generic massage with will catch nan or inf and if all quaternion components are neer zero

Efected funcions:
SetTransfom
SetOrientation
massange given to user

SetTransfom:

[ 00:00:33.913 ]: [Error] Invalid Transform Component('s) passed to Actor::SetTransform
Value's:
	Translation:X:-42.768875 Y:60 Z:-830.78723
	Orientation:X:0 Y:0 Z:0 W:-0
	Scale:X:1 Y:1 Z:1

StackTrace:
 ...

SetOrientation:

[ 00:00:21.672 ]: [Error] Invalid Quaternion passed to Actor::SetOrientation
Value:
   X:0 Y:0 Z:0 W:-0

StackTrace:
...

alternative is to use "Check" but it creates this message with is hard to read

Expression: !(value.IsNanOrInfinity() || Math::NearEqual(value.W, ACTOR_ORIENTATION_EPSILON) && Math::NearEqual(value.X, ACTOR_ORIENTATION_EPSILON) && Math::NearEqual(value.Y, ACTOR_ORIENTATION_EPSILON) && Math::NearEqual(value.Z, ACTOR_ORIENTATION_EPSILON))

[edit] the Quaternion::NearEqual is not detecting it, so is not used

@mafiesto4 mafiesto4 added enhancement New feature or request level Level building tools and components. labels Mar 18, 2024
@mafiesto4 mafiesto4 added this to the 1.9 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request level Level building tools and components.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants