Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add github_token to secrets #2370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

acidlynx
Copy link

@acidlynx acidlynx commented May 2, 2023

Fixes #

Test Plan

How do we know the code works?

.

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@google-cla
Copy link

google-cla bot commented May 2, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rfogar2
Copy link
Contributor

rfogar2 commented May 10, 2023

This looks like a breaking change. Could we instead make the new required field not required and default it to an empty string? This will have the same behaviour as previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants