Remove the use of the TestXXXX classes. #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I had to jump through a hoop because it turns out we have two classes in STU3 and Base with exactly the same name (JsonSerializerOptionExtensions). This led to ambiguous references, unless I turned one (internal) function into an extension function. But in 6.0 we might want to rename this anyway to avoid such confusions. |
Kasdejong
requested changes
May 14, 2024
Kasdejong
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TestPatient/TestXXXX classes are becoming a burden since they have not been updated (it's quite a bit of work) and they start to diverge from the actually generated poco's. Since we're going to make more changes in 6.0, I have taken the step to remove them from our source code. Our parsing frameworks are now flexible enough that we can just pick STU3 to test against (the TestXXX classes were derived from STU3 anyway).