fhirpath parsing now includes comments and whitespace into the Expression object model. #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect this will be just reviewed in the diffs, then pushed direct into the other branch before (or after) going to develop. |
…inary compatible with the previous release)
ewoutkramer
previously approved these changes
May 14, 2024
…r the delimitted identifier
Kasdejong
approved these changes
May 21, 2024
ewoutkramer
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This extends on the work in the fhirpath parsing changes to be able to capture the whitespace including comments to permit exact round trips with the Expression tree.
Related issues
#2517
Testing
There are many unit tests for this, and also tested with my fhirpath validator project locally to verify that it sucessfully roundtripped all the expressions in the R4B/R5 invariants, searchparameters and about 10 large implementation guides.
FirelyTeam Checklist