fix: fractional part from stock_div must be cash refunds (#273) #288

sakkyoi · 2024-03-01T17:04:20Z

提供個人修正 #273 的做法，

gain_stock_frac = gain_stock_div % 1  # 取 gain_stock_div 小數部分
gain_stock_div = gain_stock_frac - gain_stock_frac  # gain_stock_div 只留整數部分
gain_cash = cash_div * trader.hold_volume + gain_stock_frac * 10  # 將小數部分加進 gain_cash

其中小數部分加進 gain_cash 的部分，大部分公司都是能讓股東選擇與其他股東湊齊整數做合併，或是不合併的話以面值退還現金。由於大部分公司面額是 10 元，因此這邊直接用 10 元做計算。實際上應該要另外處理 (?)，或是直接保留小數部分? 將該欄位型態改為 float 避免 pydandic 報錯?

fix: fractional part from stock_div must be cash refunds (FinMind#273)

575a60a

linsamtw force-pushed the master branch from 18a7203 to 575a60a Compare March 23, 2024 06:13

linsamtw approved these changes Mar 23, 2024

View reviewed changes

linsamtw merged commit 3ba1e70 into FinMind:master Mar 24, 2024
1 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fractional part from stock_div must be cash refunds (#273) #288

fix: fractional part from stock_div must be cash refunds (#273) #288

sakkyoi commented Mar 1, 2024

fix: fractional part from stock_div must be cash refunds (#273) #288

fix: fractional part from stock_div must be cash refunds (#273) #288

Conversation

sakkyoi commented Mar 1, 2024