-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SparseMatrixCSR extension #864
base: master
Are you sure you want to change the base?
Conversation
49d273a
to
27d1980
Compare
27d1980
to
0c3efc8
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
==========================================
+ Coverage 93.29% 93.34% +0.05%
==========================================
Files 36 37 +1
Lines 5235 5291 +56
==========================================
+ Hits 4884 4939 +55
- Misses 351 352 +1 ☔ View full report in Codecov by Sentry. |
94ece96
to
8102774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just took a look as I was curious, nice work on factoring out some parts - this will make it easier to extend!
ext/FerriteSparseMatrixCSR.jl
Outdated
if !iszero(Ke[Kerow, permutation[i]]) | ||
_missing_sparsity_pattern_error(Krow, sorteddofs[i]) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like also this loop is never active either in tests, which seems related to above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I need @fredrikekre to help out here. The logic is the same as the for csc assembly, I just swapped the indices. I guess this is the same case as above, that we handle "too small sparse matrices"?
Towards #848 and #628 . This should show how we could assemble into custom sparse matrix formats.
TODO