Remove localhost exception #4252
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4252 +/- ##
==========================================
- Coverage 74.51% 73.95% -0.57%
==========================================
Files 339 339
Lines 22910 22914 +4
==========================================
- Hits 17072 16946 -126
- Misses 4513 4669 +156
+ Partials 1325 1299 -26
... and 18 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
AlekSi
reviewed
Apr 30, 2024
| @@ -291,13 +291,13 @@ func (h *Handler) Commands() map[string]command { | |||
|
|
|||
| // authenticateWrapper wraps the command handler with the authentication check. | |||
| // If anonymous is true, the command handler is executed without authentication. | |||
| func (h *Handler) authenticateWrapper(cmd command) func(context.Context, *wire.OpMsg) (*wire.OpMsg, error) { | |||
| func (h *Handler) authenticateWrapper(name string, cmd command) func(context.Context, *wire.OpMsg) (*wire.OpMsg, error) { | |||
There was a problem hiding this comment.
It is not quite clear what name is, and the comment wasn't updated
|
@chilagrow this pull request has merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4236.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.