-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract user creation and move to backends
package
#4248
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4248 +/- ##
==========================================
- Coverage 74.90% 74.19% -0.72%
==========================================
Files 323 325 +2
Lines 22365 22414 +49
==========================================
- Hits 16752 16629 -123
- Misses 4385 4575 +190
+ Partials 1228 1210 -18
... and 15 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny comment 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
|
||
// Password wraps a password string. | ||
// | ||
// It exist mainly to avoid issues when multiple string parameters are used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another reason is to try to hide values of that type from logs in the future.
That's experimental. I will either update more code to use that type or remove it in future PRs.
|
Description
Closes #4243.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.