Basic sessions functionality #4140
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumyantseva
added
the
not ready
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4140 +/- ##
===========================================
- Coverage 74.54% 32.60% -41.95%
===========================================
Files 353 338 -15
Lines 22675 21731 -944
===========================================
- Hits 16904 7085 -9819
- Misses 4486 13864 +9378
+ Partials 1285 782 -503
... and 196 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
reviewed
Mar 11, 2024
| }).Err() | ||
| require.NoError(t, err) | ||
|
|
||
| credential := options.Credential{ // as created in setup.setupUser |
There was a problem hiding this comment.
Just noting setup.setupUser does not create for Mongo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1554.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.