Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alexleung/dev v070 for refactor #2088

Merged
merged 181 commits into from May 12, 2024

Conversation

fedml-alex
Copy link
Contributor

No description provided.

fedml-alex and others added 30 commits March 17, 2024 23:15
[CoreEngine] replace the direct function call with posting launching …
[CoreEngine] Use the original url to download packages.
…timeout value when checking the inference is ready.
…l autoscaler's test are running (3) adding final todo item to trigger backend for the autoscaling policy.
fedml-alex and others added 27 commits April 30, 2024 19:24
[CoreEngine] update the workflow example.
[CoreEngine] fixed the deploy job issue in the workflow.
…ata_storage

Adding tags to data storage object and the corresponding pretty table…
Disabling replica release after idle secs.
[Deploy] Handle Exception during autoscaling decision; Fix a compatibility issue.
…olution

Removing field validator for resolving spacy and pydantic conflict.
Copy link

gitguardian bot commented May 11, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10012969 Triggered Generic Password c8d5b10 python/fedml/computing/scheduler/model_scheduler/autoscaler/autoscaler.py View secret
10012969 Triggered Generic Password 0c96f95 python/fedml/computing/scheduler/model_scheduler/autoscaler/autoscaler.py View secret
10012969 Triggered Generic Password cdbacbf python/fedml/computing/scheduler/model_scheduler/autoscaler/autoscaler.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@fedml-alex fedml-alex merged commit dec0f51 into alexleung/dev_branch_latest May 12, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants