Merge pull request #1815 from Fdawgs/refactor/poppler

Fdawgs · Mar 13, 2024 · eed8ffb · eed8ffb
2 parents 9857259 + 7ee47c9
commit eed8ffb
Show file tree

Hide file tree

Showing 29 changed files with 2,435 additions and 1,304 deletions.
diff --git a/.env.template b/.env.template
@@ -159,11 +159,6 @@ REQ_BODY_MAX_BYTES=
 # Leaving empty will disable bearer token auth
 AUTH_BEARER_TOKEN_ARRAY=
 
-### BINARY PATHS ##########################################
-
-# Mandatory for Linux deployments, Windows/macOS binaries already present in node-poppler module
-POPPLER_BINARY_PATH=
-
 ### OCR ###################################################
 
 # Expects true or false.

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -126,7 +126,6 @@ jobs:
                   HOMEBREW_NO_ANALYTICS: 1
                   HOMEBREW_NO_AUTO_UPDATE: 1
                   HOMEBREW_NO_INSTALL_CLEANUP: 1
-                  POPPLER_BINARY_PATH: /usr/local/bin
               run: |
                   brew install unrtf poppler
                   cp .env.template .env
@@ -135,8 +134,6 @@ jobs:
 
             - name: Run Ubuntu tests
               if: matrix.os == 'ubuntu-latest'
-              env:
-                  POPPLER_BINARY_PATH: /usr/bin
               run: |
                   sudo apt-get -y install poppler-data poppler-utils unrtf
                   cp .env.template .env

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -14,7 +14,6 @@ services:
             LOG_ROTATION_FILENAME:
             NODE_ENV: production
             HOST: 0.0.0.0
-            POPPLER_BINARY_PATH: /usr/bin/
         healthcheck:
             test: curl "localhost:${PORT:-3000}/admin/healthcheck"
             interval: 60s