Add new Serialization Feature to avoid fractions #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadlers
referenced
this pull request
in sashikanthr/jackson-modules-java8
Mar 2, 2020
* test: add initial test case * fix: fix problems in test case for issue #1 * feat: add test cases for timestamps part and nanoseconds part related to issue #1 * create a false test cases #1 * Use flag for diabling fraction * Use flag for diabling fraction * Added the flag for DurationSerializer classes * Removed test cases that are not relevant to the added Serialization Feature * Only keep requirement specific tests Some tests were set up to get an understanding of the code. They should not be kept and included in the pull request Co-authored-by: Nagisa <fuchang.2000@gmail.com> Co-authored-by: Jacob Adlers <jacob.adlers@gmail.com>
kupci
reviewed
Mar 2, 2020
| * fraction part or not. | ||
| *<p> | ||
| * Note: if enabled the feature {@link | ||
| * #WRITE_DATE_TIMESTAMPS_AS_NANOSECONDS} is ignored in {@link |
There was a problem hiding this comment.
I think some mention of the new flag should be part of the javadoc for WRITE_TIMESTAMPS_AS_NANOSECONDS..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is added to fix FasterXML/jackson-modules-java8#116