Tidy up GiftedChat component #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amerikan
changed the title
Johan-dutoit
reviewed
May 3, 2023
| @@ -447,7 +376,7 @@ function GiftedChat(props: GiftedChatProps) { | |||
| const getBasicMessagesContainerHeight = ( | |||
| composerHeight = state.composerHeight, | |||
| ) => { | |||
| return getMaxHeight()! - calculateInputToolbarHeight(composerHeight!) | |||
| return maxHeightRef.current! - calculateInputToolbarHeight(composerHeight!) | |||
There was a problem hiding this comment.
potential for NaN, as max height could be undefined.
|
|
|
@Johan-dutoit fixed the type errors, but don't think the Github actions is set up correctly. |
@amerikan my bad, was "working" on the PR. Fixed now and also added node 18. Will get the Circle CI removed soon. |
Johan-dutoit
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Unused props are not removed in this PR. Not sure why they're there, but thought I just leave them alone for now.Removed unused props.