-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes crash with: Tried to get frame for out of range index -1 [scrollToBottom (scrollToEnd of list with inverted option) only if messages available/loaded] #2358
Conversation
@fahad86 maybe i'm missing something but i have this error when i'm trying to build : |
I guess the problem you mentioned would happen when there are no properties added to the tag? Let me add some null checks. |
👋 @fahad86 please resolve the conflicts, will merge in after. |
Done. |
…sages available/loaded
@Johan-dutoit saw that there was one more conflict which I've resolved now |
Hi @fahad86 ! we have also this issue, it will not be merged ? |
I think with the refactoring for the latest version, empty messages handling has already been implemented in a different place. This PR should however still be valid for versions < 2.1.0 |
I've just checked, i'm still having the issue in prod with react-native-gifted-chat 2.1.0 |
Problem was linked to react-native. Fixed in RN 0.72 |
Without this fix we end-up having
Tried to get frame for out of range index -1
error thrown from the underlying FlatListThis is currently causing a lot of crashes on Production for us. The crashes happen when we try to navigate to the chat window directly from push notifications