Add "/hologram search" command #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OakLoaf
suggested changes
May 16, 2024
| MessageHelper.info(player, "<b>Search results:</b>"); | ||
| MessageHelper.info(player, "<b>Page %s/%s</b>".formatted(page, pages)); | ||
| holograms.stream() | ||
| .filter(holo -> holo.getData().getName().contains(search)) |
There was a problem hiding this comment.
It could be worth making the filter not case sensitive to increase returned searches.
Suggested change
| .filter(holo -> holo.getData().getName().contains(search)) | |
| .filter(holo -> holo.getData().getName().toLowerCase().contains(search.toLowerCase())) |
| page = index; | ||
| } | ||
|
|
||
| var pages = holograms.stream() |
There was a problem hiding this comment.
Instead of running 2 streams on holograms it could be worth moving the stream from line 52 here and creating an unmodifiable list with toList(). To check if the page exists you can then just run List#isEmpty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new command that allows filtering of the hologram list. The code is mostly identical to the ListCMD code, the most relevant addition being
.filter(holo -> holo.getData().getName().contains(search))and the pages calculation.