Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connects Falkonry/tracker#7468 | Serverless version migration #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

connects Falkonry/tracker#7468 | Serverless version migration #2

wants to merge 1 commit into from

Conversation

chandresh-gurbani
Copy link

@chandresh-gurbani chandresh-gurbani commented Jun 2, 2021 •
edited

Falkonry/tracker#7468

warren-falkonry
warren-falkonry reviewed Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@warren-falkonry warren-falkonry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but I think it will be better for us to hold off on sls v1->v2 merges to main/master branches to avoid having to double-refactor our manifests (#7751)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warren-falkonry warren-falkonry warren-falkonry left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@warren-falkonry warren-falkonry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chandresh-gurbani @warren-falkonry