Fix Cabinet Sorting Bug #13402 #13938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! We've actually got a fix pending for this in our private repo, it's just waiting to be tested internally, so I'll close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where stacks of the same item in a cabinet would be rearranged when sorting alphabetically.
Added a function
IsContainerto return whether or not an Item is an ItemContainer.Also modified sorting to ignore any ItemContainer. Not sure if this is the ideal solution, but it was easier than figuring out a way to break ties between similar containers.
Edit: This is my first time contributing to something open source, so if I'm doing something wrong, feedback is appreciated.