Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Berilia Improvements and Fixes #13317

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

WJohn
Copy link

@WJohn WJohn commented Jan 17, 2024

With the advent of the newly updated Berilia and with the Traitor rework, a number of minor issues became apparent to me through further playtime, and with the mashed-together versions it ended up with. This PR aims to fix up some lingering issues, and more importantly, make it a more desirable Submarine for large player counts.

Changelist and reasoning:

  • Turned the empty hallway between the Engine and central Junctions room into a bar/smoke lounge in the center of the ship. This bar also boasts a crucial new ability: a Vending Machine. The hallway was virtually unused outside of a grow-room, and should give players a place to form friendships and bonds in a large crew. More importantly, the Vending Machine uniquely gives the Berilia more late-game sustainability and independence from other ships, similar to the Winterhalter. This effectively means that, if the crew has money to spare, they can buy a few overpriced Opium bottles, Ethanol, or other essentials in a pinch when stations are few and far between.
  • Swapped the central Junctions room and empty hallway. Would've been awkward to go through the Junctions room to reach the bar from the central ladder access.
  • Added a bottom docking port in the lower airlock. Larger ships benefit more from multiple docking angles, and this ship here's the biggest. This necessitated adjusting of the Flak Cannon and its firing angles as to avoid clipping with shuttles.
  • Made the armory a bit bigger, carries two extra ammo box racks. Was overly cramped, required lightly shifting the Medbay and Gunnery to the left, but nothing drastic.
  • Added more windows in the major hallways. Easy to feel boxed in and separated from the outside on this ship, and the Typhon 2 is stealing all the good views of the endgame.
  • Replaced cameras on outside of ship with searchlights, like the R-29. Searchlights have much greater view range, and the cameras just did not see far enough to be all that useful.
  • Replaced airlocks with no-rubberband version from PR Simple no-rubberband airlock using the new Activate Out signal #12358. Bots are now able to enter/exit ship without any problem.
  • Simplified battery setup, made battery relays non-pickable. As with other ships.
  • Slight increase of reactor output from 6700 to 6800. To compensate for new searchlights.
  • Cargo Bay's left entrance now leads to upper engine, rather than Junctions room. Avoids dumping water right into all the electrics in case of flooded cargo bay.
  • Adjusted bottom central hallway vs bottom airlock access lengths. Lower airlock access' room length was way too long.
  • Slight adjustment to the far wall in the crew quarters. The bow of the ship was two centimeters off from being able to behave as an extra layer of armor, and got flooded non-stop any time it got grazed.
  • Can now stand on the tables in the crew quarters/bar. The rum bottle always fell through the table. I had considered a weapon holder, but this option can lead to entertaining crew theatrics.
  • Adjusted a lot of Junction wiring.
  • Minor aesthetic cleanup/consistency/visual tweaks throughout the ship.
  • Adjusted submarine description to mention four ballasts, instead of three.
  • Pictures:
    Berilia
    Berilia_lighting
    Berilia_Bar

    @JeroonBosch JeroonBosch self-assigned this Feb 20, 2024
    @mygamingaccount
    Copy link

    Did you test the lower docking port if it extends far enough to allow the vanilla respawn shuttles to dock?

    @WJohn
    Copy link
    Author

    WJohn commented Feb 20, 2024

    Yes, I have. All three shuttles are able to dock there, though the Flak Cannon somewhat clips into the shuttle. I can, however, lower the docking port and re-position the gun to make the docking port flush with the lower half of the ship. Should make docking look cleaner. Although, I strongly hesitate to do this because it would greatly influence the gun's firing angles and change the balance of the ship pretty dramatically.

    @WJohn
    Copy link
    Author

    WJohn commented Feb 20, 2024

    As some people have pointed out, the bottom Airlock sits uncomfortably close to the gun, resulting in clipping (and general difficulty of docking due to being recessed). I've gone and done a mockup of a possible alternative, though this adjusts the gun's firing angles noticeably, and makes the belly of the ship and the airlock more exposed, although EDC on the bottom of the ship can probably take care of most things.
    berilia_adjusted

    I won't push for this unless Jeroon decides this balance change is appropriate in the name of easier docking and no clipping issues.

    @JeroonBosch
    Copy link
    Collaborator

    Bottom docking ports are currently limited to the Kastrull, Orca 1, R-29 and both Typhons, so I wouldn't say a docking port is mandatory in the first place. I do agree though that a clipping turret isn't something I'd merge.

    Personally I think moving the Flak cannon could be a decent solution, assuming it doesn't still clip while in that spot. It's either that or removing the docking hatch altogether, or moving it to the back (where the engine is)

    @WJohn
    Copy link
    Author

    WJohn commented Feb 21, 2024

    I believe adding a bottom docking port makes sense on the Berilia because it is by far the largest submarine in the game, and larger submarines really need the extra docking space.

    And yes, I've checked, the turret no longer clips at that angle. Moving it to the back engine is a possible solution as well, though that's rather ugly and out of the way.

    Lowered docking port area, adjusted Flak Cannon location.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    3 participants