Quick fixes #1534
Merged
Quick fixes #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanisBft
added
bug
| @@ -178,7 +178,7 @@ CLASS net/minecraft/class_327 net/minecraft/client/font/TextRenderer | |||
| ARG 4 y | |||
| ARG 5 color | |||
| ARG 6 rightToLeft | |||
| CLASS class_5232 ShadowDrawer | |||
| CLASS class_5232 Drawer | |||
There was a problem hiding this comment.
This could be confused with the type of furniture. Maybe Renderer?
There was a problem hiding this comment.
Could work too, will wait a bit for opinions before renaming it
There was a problem hiding this comment.
Wouldn't it be weird to have a TextRenderer.Renderer class?
There was a problem hiding this comment.
Maybe TextDrawer to not have confusion from a plain Drawer?
There was a problem hiding this comment.
Who will confuse an inner class of TextRenderer with a furniture?
YanisBft
added
snapshot
haykam821
approved these changes
Jul 2, 2020
Gegy
approved these changes
Jul 2, 2020
Earthcomputer
approved these changes
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1373
Closes #1529
Closes #1530
Progress on #987