New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various misc changes #1372
Merged
modmuss50
merged 10 commits into
FabricMC:1.16-pre2
from
AntiquityMC:various-things-2020-05-19
Jun 7, 2020
Merged
Various misc changes #1372
modmuss50
merged 10 commits into
FabricMC:1.16-pre2
from
AntiquityMC:various-things-2020-05-19
Jun 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: liach <liach@users.noreply.github.com> Closes FabricMC#1344.
Juuxel
added
new
A PR that maps mainly new names
refactor
A PR that renames existing names.
snapshot
A PR that targets a snapshot version of Minecraft
labels
May 19, 2020
2xsaiko
reviewed
May 19, 2020
liach
reviewed
May 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, didn't we decide to use screen over GUI?
IIRC this is used for non-screen GUIs (the HUD). |
YanisBft
added
javadoc
A PR that adds or refactors javadoc.
outdated
A PR that targets an outdated branch.
labels
May 19, 2020
YanisBft
approved these changes
May 21, 2020
haykam821
approved these changes
May 21, 2020
shedaniel
reviewed
May 21, 2020
ChloeDawn
suggested changes
May 27, 2020
liach
approved these changes
May 29, 2020
liach
approved these changes
Jun 5, 2020
YanisBft
approved these changes
Jun 6, 2020
modmuss50
approved these changes
Jun 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javadoc
A PR that adds or refactors javadoc.
new
A PR that maps mainly new names
ready to merge
refactor
A PR that renames existing names.
snapshot
A PR that targets a snapshot version of Minecraft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractBlock(State).onStateReplaced(..., notify) -> moved
. Fixes AbstractBlock[State].onStateReplaced(..., notify) -> moved #1369.MOVED
flag ofsetBlockState
.ItemRenderer.renderGuiItem
-related names. Closes ItemRenderer.renderGuiItem-related names #1361.CriteriaMerger
->CriterionMerger
. No issue, but a singular sounds nicer than a plural.WololoGoal.purpleSheepPredicate
->convertibleSheepPredicate
. Closes WololoGoal purpleSheepPredicate is named wrongly #1344.MinecraftClient.(block/item)ColorMap
->(block/item)Colors