Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop 'is' prefixes for boolean fields #987

Open
Runemoro opened this issue Nov 26, 2019 · 4 comments
Open

Drop 'is' prefixes for boolean fields #987

Runemoro opened this issue Nov 26, 2019 · 4 comments
Assignees
@Runemoro @YanisBft
Labels
bug Fixes or discusses a bug within the mappings

Comments

@Runemoro
Copy link
Contributor

A few boolean fields still use the "is" prefix, which doesn't respect the conventions.
@Runemoro Runemoro self-assigned this Nov 26, 2019
@Runemoro Runemoro added the bug Fixes or discusses a bug within the mappings label Nov 26, 2019
@natanfudge
Copy link
Contributor

"Bug"

@Runemoro
Copy link
Contributor Author

"Bug"

Hm? Not respecting the conventions is a bug the same way using a name using British spelling or making a typo is.

@liach
Copy link
Contributor

liach commented Nov 29, 2019

Most of the time the is prefix is extraneous (mainly for adjective phrases)

@YanisBft YanisBft self-assigned this Mar 19, 2020
@YanisBft
Copy link
Contributor

If anyone wants to help, here's a very quick shell script I made to find all fields and parameters starting with "is": https://drive.google.com/open?id=1Ab3AVMFI9PaGeknCo-6C3gUKW8_xnpPY

@dexman545 dexman545 mentioned this issue May 30, 2020
Closed
dexman545 added a commit to dexman545/yarn that referenced this issue Jun 11, 2020
@dexman545
Removed 'is' prefix from field/param names as per FabricMC#987
63489f6
@YanisBft YanisBft mentioned this issue Jul 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Runemoro Runemoro

@YanisBft YanisBft

Labels
bug Fixes or discusses a bug within the mappings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Runemoro @liach @YanisBft @natanfudge