Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How should BlockView arguments be named? #1098

Closed
LambdAurora opened this issue Feb 8, 2020 · 6 comments
Closed

How should BlockView arguments be named? #1098

LambdAurora opened this issue Feb 8, 2020 · 6 comments
Labels
discussion vote A vote on a name refactor

Comments

@LambdAurora
Copy link
Contributor

BlockView arguments should be named view or world?
@Prospector
Copy link
Contributor

I personally like world for all the world-like parameters

@liach
Copy link
Contributor

liach commented Feb 8, 2020

I prefer view. Guess we can vote on this comment (:+1: and :-1:)

@liach liach added the vote A vote on a name refactor label Feb 8, 2020
@Juuxel
Copy link
Member

Juuxel commented Feb 8, 2020

Hm, aren't some of the *View interfaces only implemented on World and some implemented on Chunk as well?

@LambdAurora
Copy link
Contributor Author

BlockView is implemented in something for rendering, worlds and chunks.
But WorldView is only implemented by world.

@liach
Copy link
Contributor

liach commented Feb 8, 2020

Result is pretty clear. people support world overwhelmingly, and let's just use world

@liach liach mentioned this issue Feb 8, 2020
Merged
@liach
Copy link
Contributor

liach commented Feb 8, 2020

Closing as we've decided and have applied to #1095.

@liach liach closed this as completed Feb 8, 2020
@LambdAurora LambdAurora mentioned this issue Feb 12, 2020
Merged
@liach liach mentioned this issue Feb 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion vote A vote on a name refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Prospector @Juuxel @liach @LambdAurora