Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWorld -> GenView #1133

Closed
liach opened this issue Feb 23, 2020 · 6 comments
Closed

IWorld -> GenView #1133

liach opened this issue Feb 23, 2020 · 6 comments
Labels
discussion refactor A PR that renames existing names. vote A vote on a name refactor

Comments

@liach
Copy link
Contributor

liach commented Feb 23, 2020

A followup of ancient #448. #1098 gives me the idea that interfaces can be named view, and this interface is a view for potentially async world generation view, hence GenView should suffice. Please vote.

@liach liach added refactor A PR that renames existing names. vote A vote on a name refactor labels Feb 23, 2020
@i509VCB
Copy link
Contributor

i509VCB commented Feb 23, 2020

Did we want to use the Gen abbreviation or Generation

On the case of IWorld currently, it is right where the split between regular World, Client and Server worlds and ChunkRegion (very commonly used in World gen) begins.

Whether we should use World or View is another question as IWorld starts to define some worldly functions such as the existence of state scheduling, difficulties and chunk managers.

The mentions of IWorld's use in world gen is a good argument for why Gen/GenerationView could work, however I feel a name like IntermediaryWorld could work but that also doesn't compensate for the possible world gen context this would be used within.

GenerationView or IntermediaryWorld are my two choices but I would like to see some more arguments before a firm decision.

@valoeghese
Copy link
Contributor

iapprove

@Juuxel
Copy link
Member

Juuxel commented Feb 23, 2020

I like @i509VCB's GenerationView.

@jaskarth
Copy link
Contributor

I vote for GenerationView as well.

@i509VCB
Copy link
Contributor

i509VCB commented Mar 29, 2020

Would like to put some steam back into the discussion here.

The listed options I've seen mentioned in this issue so far:

GenView
GenerationView
IntermediaryWorld
GeneratableWorld (basically #448 with new naming standard)

My opinions on the above:
GenView is nice and short but Gen does not very explicit with the abbrivation's meaning (General, Generation, Genji?)

GenerationView and GeneratableWorld both fall in the same category of being much more explicit than GenView

IntermediaryWorld is a compromise as not all world types are actually generatable (Client worlds).
Also due to the fact this class is an interface, the intermediary portion of the name says this represents a sort of "partial definition" for a world or a worldly functions.

Some other ideas:
ProtoWorld (inspired by the sponge api name and based on the Greek word proto, which in this context would be used to mean basic or prototype).

PrimativeWorld (assuming we use primative in the sense of a simplistic object), issue I see is the connotation with socital definition of primitive which makes no sense with a type of world

@YanisBft
Copy link
Contributor

Closed by #1350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion refactor A PR that renames existing names. vote A vote on a name refactor
Projects
None yet
Development

No branches or pull requests

6 participants