Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PointDistribution feature #505

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AhmetNSimsek
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 1284 lines in your changes are missing coverage. Please review.

Comparison is base (5a0e6b3) 36.81% compared to head (d573252) 50.69%.
Report is 296 commits behind head on main.

Files Patch % Lines
siibra/volumes/volume.py 44.18% 120 Missing ⚠️
siibra/features/feature.py 48.09% 109 Missing ⚠️
siibra/explorer/url.py 0.00% 107 Missing ⚠️
siibra/volumes/parcellationmap.py 18.25% 103 Missing ⚠️
siibra/core/region.py 62.34% 90 Missing ⚠️
...bra/features/connectivity/regional_connectivity.py 25.97% 57 Missing ⚠️
siibra/retrieval/datasets.py 51.81% 53 Missing ⚠️
siibra/explorer/util.py 0.00% 51 Missing ⚠️
siibra/configuration/factory.py 50.98% 50 Missing ⚠️
...a/features/tabular/regional_timeseries_activity.py 25.00% 48 Missing ⚠️
... and 38 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #505       +/-   ##
===========================================
+ Coverage   36.81%   50.69%   +13.87%     
===========================================
  Files          61       70        +9     
  Lines        5421     6518     +1097     
===========================================
+ Hits         1996     3304     +1308     
+ Misses       3425     3214      -211     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek
Copy link
Collaborator Author

Need to implement a way to transform the coordinates if the values are collected from a different resolution etc.
Use config to convey transformation data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants