Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to timeseriesaggregation #82

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ddceruti
Copy link
Contributor

Fixed a Pandas FutureWarning, improved slightly two exceptions raised so that the complete traceback is preserved and deleted a unused import.

tsam\timeseriesaggregation.py:875: FutureWarning: A value is trying to be set on a copy of a DataFrame or Series through chained assignment using an 
inplace method.
The behavior will change in pandas 3.0. This inplace method will never work because the intermediate object on which we are setting values always behaves as a copy.

For example, when doing 'df[col].method(value, inplace=True)', try using 'df.method({col: value}, inplace=True)' or df[col] = df[col].method(value) instead, to perform the operation inplace on the original object.

@l-kotzur l-kotzur self-requested a review January 26, 2024 16:49
@l-kotzur
Copy link
Collaborator

@ddceruti Thanks a lot for the update and the merge request.

@adbuerger mentioned further depreciation warnings with pandas 3.0. I will fix these together with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants