Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pandas issue, fix sum for distribution representation inlc. min max vals, add possibility to define segment representation and update the default example #72

Merged
merged 14 commits into from Jun 28, 2023

Conversation

l-kotzur
Copy link
Collaborator

No description provided.

@l-kotzur
Copy link
Collaborator Author

@rschwarz Somehow one of the tests fails with the new pandas version: https://github.com/FZJ-IEK3-VSA/tsam/actions/runs/5401641896/jobs/9811733821

We will fix it and then release it.

@maximilian-hoffmann Can you take a look at this? The branch with the isolated changes due to the new pandas version > 2.0.0 is here: https://github.com/FZJ-IEK3-VSA/tsam/tree/pandas_fix

I cannot figure out why the results change for the segmentation... although it are only small changes. If you feel comfortable with it, we can adapt the results.

@l-kotzur l-kotzur mentioned this pull request Jun 28, 2023
@rschwarz
Copy link
Contributor

Possible some of the reformulated pandas expressions are not actually equivalent to what was there before. I followed the general pattern of suggested changes in other code bases and the hints given by the deprecation warning. But, lacking an understanding of the code in context, might have introduced a different behavior.

I believe that I did run the tests successfully locally, but it's been a while...

@l-kotzur
Copy link
Collaborator Author

I think it is a problem of the test itself.

@l-kotzur
Copy link
Collaborator Author

New release 2.3.0

@rschwarz Thanks again for finding and fixing the bug.

@l-kotzur l-kotzur merged commit f975025 into master Jun 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants