Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization hds and hp for system setups without hot water storage #332

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

Hoppe-J
Copy link
Contributor

@Hoppe-J Hoppe-J commented May 6, 2024

Additional function for heating system setups without hot water storage.
Connection between HP and HDS directly.
Additional example and tests.

- if no heating storage is implemented (Hp connected directly with hds) the massflow of hds system is calculated by hp model
… massflow and hot water storage

some todos to fix and verification of constants
…t and thermal conductivity of screed and heat transfer screed to air
# Conflicts:
#	hisim/components/heat_distribution_system.py
- calculation of time constant if no massflow based on flexible parameters
- add new parameters from hds model in system setups
- fixing bug in hds tester
…t of hds model

--> more flexible for future models
…ot water storage --> connection heat pump to hds directly

- adapt system setups and tests to "new" parameters from hds model and hp model
- new system setup example for heating systems without hot water storage
@Hoppe-J Hoppe-J marked this pull request as draft May 7, 2024 09:18
- clean up hds config in system setups
- additional usage of simple_hot_water_storage.py for system setup with storage in serie to hds and hp
@Hoppe-J Hoppe-J marked this pull request as ready for review May 8, 2024 14:10
…l storage --> water pump runs in both operation modes with constant massflow (checked with polysun simulation if operation modes are right)

- some restructuring due to errors with mypy in combination with units and Quantity class
@Hoppe-J
Copy link
Contributor Author

Hoppe-J commented May 23, 2024

@noah80 @k-knosala
Change parameter if hot water storage is in system to "PositionHotWaterStorageInSystemSetup" with enum class in hp and hds model.
Hopefully it will be easier to understand now.

- in some timestep dhw storage sends zero as input to dhw controller of hp
- leads to more switching of hp between sh and dhw mode
- solution: save last temperature input in dhw controller and if there will be a zero restore this temperature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant