New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
District_EMS_Controller #322
Open
Hoppe-J
wants to merge
11
commits into
FZJ-IEK3-VSA:main
Choose a base branch
from
Hoppe-J:JHo_District_EMS
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rict level and hp are in "contracting" of district) with building ems
- implement list in "get_dynamic_output" function in dynamic_component.py with "used" outputs due to get the right outputs if tag and sourceweights are equal --> without list only one output will be used if tags and sourceweight have the same values --> for ems on district level it will be important to have the same tags and sourceweight for some buildings - implment list and componenttype in controller_l2_energy_management_system.py
deliver a constante temperature or thermal power in every single time step
- new function in dynamic_component.py to get all outputs - implement new function in ems controller_l2_energy_management_system.py to loop every output if there the source weight are equal --> no additional list or string splitting anymore
# Conflicts: # hisim/components/controller_l2_energy_management_system.py
- change label for outputs in dynamic_component.py back to old version due to conflicts in creating outputs with equal tag and source weight --> label of newest version write the same attribute so outputs will be overwritten if they have same tag and weights
# Conflicts: # hisim/components/controller_l2_energy_management_system.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a small implementation of a list of "used" outputs of ems component.
Problem was when simulating an ems on district level with 2 households which should recieve the same amount of surplus electricity and households have the same tags and sourceweights in connection with ems. The target output of the district ems is just working for household 1. This is due to the functions "sort_source_weights_and_components" and "get_dynamic_output" in ems_controller modell while searching for outputs based on tags and sourceweight.
With the "new" list, outputs are saved and can't used twice.
Add a new compononettype for defining surplus in districts