Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement remove unused things #2152

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jaapmarcus
Copy link
Member

No description provided.

@BelleNottelling
Copy link
Member

If anyone has these registrars enabled, deleting them will lead to a broken installation..

@jaapmarcus
Copy link
Member Author

If anyone has these registrars enabled, deleting them will lead to a broken installation..

It is using the resellerclub api that was broken for a few months...

So I don't think they would be used.

Or we could change the registrar in tld_registrar to ResellerClub they are using the same api . Only with different branding

@BelleNottelling
Copy link
Member

If anyone has these registrars enabled, deleting them will lead to a broken installation..

It is using the resellerclub api that was broken for a few months...

So I don't think they would be used.

Or we could change the registrar in tld_registrar to ResellerClub they are using the same api . Only with different branding

I'd be really nice to have telemetry right now, we'd be able to see if people for example held back without updating because it broke / see if anyone actually used the variations that extended the ResellerClub integration.

@BelleNottelling
Copy link
Member

GetTlds is gone, so that portion of this PR is complete.

I agree that the registrars that just extend Resellersclub are a bit of a sore thumb, but I still hold the opinion we should make the removal of them clean for existing installations & ensure that people won't find that their system unexpectedly bricks itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants