Refactor Library Classes and Path Handling #1843
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admdly
changed the title
admdly
force-pushed
the
refactor/library
branch
from
4e3e48b
to
9f9e36e
Compare
admdly
force-pushed
the
refactor/library
branch
6 times, most recently
from
ed21e97
to
8d0e1f6
Compare
Refactor path handling to use `symfony/filesystem` `Path` normalization, where appropriate.
Refactor 'FOSSBilling` library classes to remove DI dependency, where possible.
Refactor `FOSSBilling\Tools` functions in favour of native PHP functionality, where available.
admdly
force-pushed
the
refactor/library
branch
from
8d0e1f6
to
2672ff6
Compare
* Cache extension configs * Adjusted the tests * Use ArrayAdapter
admdly
force-pushed
the
refactor/library
branch
from
830175f
to
a96eefd
Compare
admdly
force-pushed
the
main
branch
3 times, most recently
from
b08f65b
to
b94d932
Compare
admdly
added
merge-hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
FOSSBillinglibrary classes to remove DI dependency, where possible. Also refactorFOSSBilling\Toolsfunctions in favour of native PHP functionality, where available.Additionally, refactor path handling to use
symfony/filesystemPathnormalization, where appropriate.