Update owndomain handling to accept FQDN #1149
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -148,11 +148,6 @@ public function addItem(\Model_Cart $cart, \Model_Product $product, array $data) | |||
|
|
|||
| $productServiceFromList = $productFromList->getService(); | |||
|
|
|||
| // @deprecated logic | |||
There was a problem hiding this comment.
This cannot be removed. Existing core modules still use it
Update owndomain handling to accept a FQDN as one field, rather than separate SLD and TLD, and to instead detect the TLD.
admdly
force-pushed
the
fix/domain-tld-period
branch
from
651dc05
to
ef30e9e
Compare
admdly
force-pushed
the
main
branch
3 times, most recently
from
b08f65b
to
b94d932
Compare
|
@admdly not sure if you're still working on this or not, but I believe this package will be incredibly valuable in our ability to perform proper validation: https://github.com/jeremykendall/php-domain-parser. We can use it to extract info like the suffix, domain, subdomain, ect & I think this section from their readme highlights why it's superior to what we'd (most likely) end up building:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update owndomain handling to accept a FQDN as one field, rather than separate SLD and TLD, and to instead detect the TLD.