Fix testing #566
Fix testing #566
Conversation
Otherwise tests attempt to use libtest_static-executable unconditionally, and fail, because it may not exist.
ziemek99
dismissed
their stale review
After taking a closer look I couldn't understand one of the changes.
| IN=$2 | ||
| OUTF=$3 | ||
| OUTP=$4 | ||
| FLIF=./flif |
There was a problem hiding this comment.
By using ./ the script will look for the binary in the same directory as itself, which is tools. That's not the case here – gitignore gives us a hint:
# binarys
src/flifSo by default you'll find the binary in src folder, not tools. I looked into my local copy (which I compiled previously) and sure enough, there it was. Hardcoding a path to a binary makes it impossible to use this script if the binary isn't stored there. If someone installed FLIF in their system by (sudo) make install, then the binary will be somewhere in system directories, so ./flif won't work in this case, too.
| FLIF=$1 | ||
| IN=$2 | ||
| OUTF=$3 | ||
| FLIF=./flif |
There was a problem hiding this comment.
Same as above – this shouldn't be hardcoded, especially not in this way.
The first commit makes usage of
libtest_staticconditional on whether we're building that executable.The second commit gets rid of unnecessary bash-isms making the scripts usable with a regular sh (such as that found on BSD-systems).
I do not know, why changes to the processing of positional arguments is necessary -- but they are. The scripts are never passed the path to the just-built
flif-executable.