Skip to content

Commit

Permalink
fix revert not interrupt execution (#2)
Browse files Browse the repository at this point in the history
  • Loading branch information
bxq2011hust committed Jun 5, 2023
1 parent 16c6674 commit 922d385
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 24 deletions.
22 changes: 0 additions & 22 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions src/fbei.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use crate::Error;
use evmc_vm::{
Bytes32, ExecutionMessage, MessageFlags, MessageKind, StatusCode, StorageStatus, Uint256, Address,
Address, Bytes32, ExecutionMessage, MessageFlags, MessageKind, StatusCode, StorageStatus,
Uint256,
};
use log::{debug, log_enabled, Level};
use sha3::Digest;
Expand Down Expand Up @@ -329,7 +330,11 @@ impl EnvInterface for EnvironmentInterface {
let caller = "revert";
match &self.wasm_memory {
Some(wasm_memory) => {
wasm_memory_read(wasm_memory, &store, data_offset as usize, buffer, caller)
if self.host_context.get_host_context().version >= 0x03040000 {
Err(Error::Revert(String::from_utf8_lossy(buffer).to_string()))
} else {
wasm_memory_read(wasm_memory, &store, data_offset as usize, buffer, caller)
}
}
None => Err(Error::VMInternalError(format!(
"{} failed, no wasm_memory",
Expand Down
2 changes: 2 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ pub enum Error {
InvalidParameter(String),
VMInternalError(String),
InvalidReturnStatus(i32),
Revert(String),
}

impl fmt::Display for Error {
Expand All @@ -67,6 +68,7 @@ impl fmt::Display for Error {
Error::InvalidParameter(message) => write!(f, "InvalidParameter, {}", message),
Error::VMInternalError(message) => write!(f, "VMInternalError, {}", message),
Error::InvalidReturnStatus(code) => write!(f, "InvalidReturnStatus, {}", code),
Error::Revert(message) => write!(f, "Revert, {}", message),
}
}
}
Expand Down

0 comments on commit 922d385

Please sign in to comment.