Tournament game service #921
Conversation
| @@ -415,7 +415,8 @@ async def test_handle_action_GameOption( | |||
| assert game.max_players == 7 | |||
| # I don't know what these paths actually look like | |||
| await game_connection.handle_action("GameOption", ["ScenarioFile", "C:\\Maps\\Some_Map"]) | |||
| assert game.map_file_path == "maps/some_map.zip" | |||
| assert game.map_name == "some_map" | |||
| assert game.map_scenario_path == "C:/Maps/Some_Map" | |||
There was a problem hiding this comment.
since game is a mock the setter is not invoked and map_file_path is not set by the setter
| def wait_launched(self, param): | ||
| pass | ||
|
|
||
| def wait_hosted(self, param): | ||
| pass |
There was a problem hiding this comment.
Do we need these in the base class? They only make sense for automatch games.
| @@ -516,23 +518,23 @@ def get_player_mean(player: Player) -> float: | |||
| if game_options: | |||
| game.gameOptions.update(game_options) | |||
|
|
|||
| mapname = re.match("maps/(.+).zip", map_path).group(1) | |||
| map_name = re.match("maps/(.+).zip", map_path).group(1) | |||
There was a problem hiding this comment.
Can we refactor the regex?
There was a problem hiding this comment.
How about just making use of the properties you added to the Game class? The map_file_path is already being set on line 532.
map_name = game.map_name| make_game_options: Callable[[Player], GameLaunchOptions] | ||
| async def launch_server_made_game( | ||
| self, | ||
| game: Game, |
There was a problem hiding this comment.
Could make an intermediate class AutomatchGame
|
|
||
| def is_confirmation_overdue(self): | ||
| time_passed = datetime.utcnow() - self.created_time | ||
| return time_passed.seconds > self.response_time_seconds + 5 |
There was a problem hiding this comment.
Why hardcode +5 here? Just set the response time to 35 seconds?
There was a problem hiding this comment.
I did give the client 5 more seconds to answer because of network delay etc.
What do you mean by just set the response time higher? That would also cause the client to display a longer time to the user.
There was a problem hiding this comment.
Ok I see. I didn't catch that the response time is sent to the client.
1-alex98
force-pushed
the
feature/tournament
branch
from
6bb54ed
to
f5442eb
Compare
1-alex98
force-pushed
the
feature/tournament
branch
from
f5442eb
to
a93560d
Compare
| @@ -0,0 +1,766 @@ | |||
| [*] | |||
| charset = utf-8 | |||
There was a problem hiding this comment.
I need to look into this editorconfig stuff. Would probably be best to do it in a separate PR. This file also looks like it has way too much stuff in it. I would want to trim out anything we don't need.
| @@ -141,6 +140,10 @@ async def _handle_rating_queue(self) -> None: | |||
| async def _rate(self, summary: GameRatingSummary) -> None: | |||
| assert self._rating_type_ids is not None | |||
|
|
|||
| if summary.rating_type is None: | |||
| self._logger.debug(f"Not processing game {summary.game_id} since it is not rated.") | |||
There was a problem hiding this comment.
We don't use f-strings in log messages.
| self._logger.debug(f"Not processing game {summary.game_id} since it is not rated.") | |
| self._logger.debug("Not processing game %s since it is not rated.", summary.game_id) |
Closes #675