Feature/#125 enhance parse moderator event to include player names

[magge-faf]

This PR addresses issue #133 by adding the player name to the moderator parser

Outlined Steps:

1. Renamed fromInt to fromArmy to align with the naming convention used in method parseGiveResourcesToPlayer. This makes it more readable when working with the armies object.
2. Set default values for playerNameFromArmy and playerNameFromCommandSource.
3. Retrieved playerNameFromArmy from the armies object (similar to parseGiveResourcesToPlayer).
4. Retrieved playerNameFromCommandSource via activeCommandSource from the armies object.

This allows us to access the player names in Mordor like in the following image (I locally imported the faf-java-commons into Mordor and tested the output):

Click to reveal images about the output

@Garanas, the next step would be to bring those events officially to Mordor as seen in the image - I will raise an issue there later/tomorrow. Code is already in the pipeline.

Thanks in advance for your code review @Brutus5000, @Garanas, @Sheikah45

Fixes #133

[Sheikah45]

Gotta fix conflicts though

[magge-faf]

My bad, fork was not in sync and somehow made a mess with the following rebase. I recreated the #125 branch based on the synced develop branch from FAF - This should resolve it, shouldn't?

[Garanas]

Small steps but great progress 👍 , this looks good!

[magge-faf]

Eh, I changed activeCommandSource by accident as well. I will revert that.

Edit: Or was it wrong, tho? @Garanas Can you confirm if -1 or -2 for activeCommandSource?

[Garanas]

I don't think the default value matters, it should always be defined. Observers can not enable the command source, so a value of -1 is not possible. But if you want to be sure-sure, then take a default value of -2

[magge-faf]

Thanks for clarification. -2 it is.

[Sheikah45]

I would make the command source nullable as well for similar reasons the strings were null for the default values. It is better to not have magic numbers when null can do.

[magge-faf]

@Sheikah45 Shouldn't we make fromArmy null as well because of similar default reasons, then?

[Sheikah45]

I would think so yes

[magge-faf]

Thanks for the insights. Additionally, I have thrown in another null check in case

Map<String, Object> army = armies.get(activeCommandSource); is null before accessing playerNameFromCommandSource - have done the same for playerNameFromArmy

[Sheikah45]

@magge-faf Sorry kinda of forgot about this. Is this in a good place for you?

[magge-faf]

Yes, the PR is finished for me. Don't sweat about it, I know how busy you are with far more important stuff.

I would have made a reminder-ping about this PR in a few days. It wasn't affecting my work in Mordor so far, because I can simply import the changes locally.