Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance parseModeratorEvent to Include Player Names #133

Closed
magge-faf opened this issue Apr 13, 2024 · 0 comments · Fixed by #134
Closed

Enhance parseModeratorEvent to Include Player Names #133

magge-faf opened this issue Apr 13, 2024 · 0 comments · Fixed by #134

Comments

@magge-faf
Copy link
Contributor

Extends #121

We need to update the parseModeratorEvent method to include more detailed information in the ModeratorEvent object. After this, we can get feedback from the Moderator Team via an updated Mordor version.


Currently, we have included the event time, message content, fromInt and activeCommandSource which output is in Mordor this following:

image

But we also need to view the player names through the army and command source, as well as the corresponding army number from which the message originated. That allows us to detect any potential data tampering. And of course to be able to see a player name instead of a number related to the moderator event.

We can further develop this "detect tampered data" feature in the next milestone.


Example output how it can be later seen in Mordor:

image


a, Player Name (Army) can be "easily" manipulated from an attacking force
b, Player Name (Command Source) should be much harder to manipulate

Same for:

c, Active Command Source/Sender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant