New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AttackGroundTries
and Othuy Lightning Storm
#6166
base: deploy/fafdevelop
Are you sure you want to change the base?
Conversation
Fixes lightning storm ground attacking Previous commit prevents Scathis state locking up when losing target when in firing state that required this target check
fix for custom base class not being called, needed for lightning storm to work
needs testing for IdleState OnFire, which is rarely called but is possible
Fixes their tracking of how many ground attacks they've done
@@ -898,7 +899,7 @@ DefaultProjectileWeapon = ClassWeapon(Weapon) { | |||
|
|||
-- wait reload time + 2 seconds, then force the weapon to recheck its target | |||
WaitSeconds((1 / self.Blueprint.RateOfFire) + 3) | |||
self:ResetTarget() | |||
self:ResetTarget() -- this breaks AttackGroundTries for bombers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great find!
`SetFireControl`, `IsFireControl`, `WeaponHasTarget`, and `GetFireClockPct`
Tracking of CanFire changes Tracking of weapon fire rates Tracking of engine calls in FireReadyState Add fired shot/rack count debugging
Check for a base class for FireReadyState OnLostTarget fixes beam weapons not stopping immediately Fix shooting 1 extra shot when retargeting a salvo with a salvoDelay
The main change is the salvo retargeting feature.
The retargeting feature does solve being able to restart salvos while still shooting on the last shot of AttackGroundTries. It also allows cool retargeting in the middle of a salvo with different orders, so you can't lose an entire salvo to a misclick (for example scathis). |
Description of the proposed changes
Fixes the ability of
AttackGroundTries
for bombers and fixes an off by one issue for other units. Annotates the field.As a bonus, fixes lightning storm spawned from Ythotha too (cheat menu spawn and Ythotha spawn act differently).
Testing done on the proposed changes
Checklist