Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Miasma shield penetration #6163

Conversation

clyfordv
Copy link
Contributor

@clyfordv clyfordv commented May 10, 2024

Issue:
With the airburst on the Miasma, if the child projectile is spawned around the same tick as it would hit a shield, that child projectile would pass through the shield. This was not random, and consistent enough that it's likely exploitable*.

*Edit: forgot that I had the Miasma on perfect accuracy--not exploitable, just annoyingly random.

Solution:
Remove the secondary projectile that spawns with the airburst, and leave all the effects and damage dealing up to the main one.

Other attempted solutions:
I tried moving all damage dealing on the primary projectile while keeping the effects on the secondary (the secondary would still penetrate in some cases, but wouldn't do damage, and though repeatable the odds of it happening accidentally are low so it'd be a minor visual irregularity). The issue with this is spawning a projectile on a projectile, and not destroying the original projectile immediately, causes the strategic icon to stutter, which looks bad.

Afterthoughts:
Ballistic behavior is now in line with other artillery (no airburst). Damage over time remains. Miasma cloud effect is still there, but the impact looks a little uninspired without the secondary projectile emitter trail, and it could use a more impactful (...) visual effect when it hits something.

@MrRowey MrRowey linked an issue May 10, 2024 that may be closed by this pull request
@Garanas Garanas added the area: balance related to units balance label May 11, 2024
@Garanas Garanas requested a review from MrRowey May 11, 2024 13:06
@MrRowey MrRowey merged commit 94713b2 into FAForever:deploy/fafdevelop May 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: balance related to units balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

T2-Artillery hits through shield without collision
3 participants