Show player divisions in scoreboard #6160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackYps
added
area: ui
|
🤔 , I thought we also merged the images of the badges at some point in the past. We could use those instead of the text |
|
According to this #4263 using the images causes problems with the layout. I have no experience with the ui elements of the game, so I don't feel competent to possibly address these problems. But even if they do, it doesn't hurt to have the text solution in the meantime. |
|
What will this show in custom games tho? and how will it affect Scoreboard UI Mods ? |
|
Custom games still show the rating. UI mods are unaffected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Show the division of players in the scoreboard instead of rating if available (i.e. in matchmaker games)
Closes #4258
Testing done on the proposed changes
Tested them on a matchmaker replay, as well as a normal game to make sure that the rating still shows up when no divisions are available.
The missing space between division and subdivision is because the added space in the game options is not present in current replays. This is just an artefact of the testing process and will be fixed once the release happened.
Checklist