Fix UEF SACU fire rate upgrade using inaccurate fire rate value

[lL1l1]

Description of the proposed changes

Changes the UEF SACU's fire rate upgrade from 1.82 fire rate to 2.00 fire rate because 1/1.82 = 0.5494 so it rounds down to 0.5 fire delay, which is equal to 2 fire rate. Also updates the localizations.

Testing done on the proposed changes

Spawn a UEF combatant preset and step 5 ticks while paused to confirm that it does shoot 2 times per second with the 1.82x fire rate.

Checklist

• Changes are documented in the changelog for the next game version

[Garanas]

We recently introduced a test suite for invalid fire rates, see also;

fa/tests/blueprint/unit.spec.lua

Lines 278 to 315 in f7420f6

	local rateOfFire = weaponBlueprint.RateOfFire
	if rateOfFire then
	luft.test(
	"Rate of fire",
	function()
	luft.expect(rateOfFire).to.be.number()
	if rateOfFire > 6.6666 then
	luft.expect(rateOfFire).to.be.close.to(10)
	elseif rateOfFire > 4.0 then
	luft.expect(rateOfFire).to.be.close.to(5)
	elseif rateOfFire > 2.8571 then
	luft.expect(rateOfFire).to.be.close.to(3.333)
	elseif rateOfFire > 2.2222 then
	luft.expect(rateOfFire).to.be.close.to(2.5)
	elseif rateOfFire > 1.8182 then
	luft.expect(rateOfFire).to.be.close.to(2.0)
	elseif rateOfFire > 1.5384 then
	luft.expect(rateOfFire).to.be.close.to(1.666)
	elseif rateOfFire > 1.3333 then
	luft.expect(rateOfFire).to.be.close.to(1.428)
	elseif rateOfFire > 1.1765 then
	luft.expect(rateOfFire).to.be.close.to(1.25)
	elseif rateOfFire > 1.0526 then
	luft.expect(rateOfFire).to.be.close.to(1.111)
	elseif rateOfFire > 0.9524 then
	luft.expect(rateOfFire).to.be.close.to(1.0)
	elseif rateOfFire > 0.8696 then
	luft.expect(rateOfFire).to.be.close.to(0.909)
	elseif rateOfFire > 0.8 then
	luft.expect(rateOfFire).to.be.close.to(0.833)
	elseif rateOfFire > 0.7407 then
	luft.expect(rateOfFire).to.be.close.to(0.769)
	end
	end
	)
	end

Would you be interested to enhance the test suite to catch these cases too?

[lL1l1]

This isn't a balance change, its effect is only for the UI.

[lL1l1]

There's only 4 units with fire rate enhancements, does it need a test?

[Garanas]

oh, I miss understood then. I thought this was a more broader problem! Great solution however 😃

[MrRowey]

This isn't a balance change, its effect is only for the UI.

you have changed a Unit Fire Rate tho so that is a balance Change

[Garanas]

This isn't a balance change, its effect is only for the UI.

you have changed a Unit Fire Rate tho so that is a balance Change

If I'm not mistaken, practically it is the same value due to rounding 😃 ! It's now just more obvious what the value is.

[Garanas]

It appears the tests do not run on this branch 🤔 , any idea as to why that is?

[lL1l1]

Not sure why it doesn't show up in the "checks" tab of the PR, but the tests do run on my fork's page https://github.com/lL1l1/fa/actions/workflows/test.yaml

[MrRowey]

That's gin then feel free to merge then when you happy jip