Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitviewDetail: do not display the Bouncer's targeting laser #6119

Merged
merged 4 commits into from Apr 30, 2024
Merged

UnitviewDetail: do not display the Bouncer's targeting laser #6119

merged 4 commits into from Apr 30, 2024

Conversation

Basilisk3
Copy link
Contributor

@Basilisk3 Basilisk3 commented Apr 25, 2024 •
edited

Description of the proposed changes

The Bouncer's targeting laser is a purely aesthetical weapon and does not deal any damage.

Testing done on the proposed changes

The unit still functions normally. According to the wiki, WeaponCategory is a deprecated attribute and changing it will not affect the weapon.

Checklist

  • Changes are documented in the changelog for the next game version

lL1l1
lL1l1 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@lL1l1 lL1l1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WeaponCategory is used for some AI threat calculation and UI things, but yes it's not read by the engine (doesn't show up in blueprint viewer).

@lL1l1 lL1l1 merged commit 7f217a4 into FAForever:deploy/fafdevelop Apr 30, 2024
5 checks passed
@Basilisk3 Basilisk3 deleted the BouncerUVD branch April 30, 2024 23:37
@lL1l1 lL1l1 added area: ui Anything to do with the User Interface of the Game ui: unit-stats related to issues in unit stats/tooltips labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lL1l1 lL1l1 lL1l1 approved these changes

Assignees
No one assigned
Labels
area: ui Anything to do with the User Interface of the Game ui: unit-stats related to issues in unit stats/tooltips
Projects
None yet
Milestone
Development iteration II of 2024
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Basilisk3 @lL1l1