Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect table being inserted into AI marker function #6118

Conversation

relent0r
Copy link
Contributor

Description of the proposed changes

A very small change that corrects an error in a default AI marker function that was unused until now.

Testing done on the proposed changes

Validated that the marker table is being populated and returned

Additional context

Noted by Grandpa Sawyer as he was wanting to use it for a campaign mission.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

Jip I haven't updated the changelog yet, not sure if you still want to do the create file with name of next version thing still or not?

@Garanas
Copy link
Member

Garanas commented Apr 27, 2024

Jip I haven't updated the changelog yet, not sure if you still want to do the create file with name of next version thing still or not?

When it is done - but until then, the current approach will have to do 😃 !

@Garanas Garanas added the area: AI related to AI functions label Apr 27, 2024
@Garanas
Copy link
Member

Garanas commented Apr 29, 2024

@relent0r could you add the changelog entry in the new setup? See also /changelog/snippets and then you'd need to create a ai.6118.md file, which contains just the entry that you introduced to 3810.md.

@lL1l1 lL1l1 merged commit f80b936 into FAForever:deploy/fafdevelop Apr 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: AI related to AI functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants