Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mass from dead trees and tree groups #6087

Merged
merged 1 commit into from Apr 17, 2024

Conversation

BlackYps
Copy link
Contributor

This is an experimental change to allow studying the engineer behaviour when trees have no mass.
I only included the dead trees so far, these are an issue on Badlands, where they are interspersed with important rocks.
I can trivially add this change for other trees if wanted, because I had chatGPT write me a nice script to automate it.

This approach is way easier for testing than having to edit the armature as done in #6063
This is intended to be used for testing on fafdevelop, it's not ready to be included in game patch at the moment.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@Garanas
Copy link
Member

Garanas commented Apr 16, 2024

Could you share the script? 😃

And do you want me to merge this in for testing?

@BlackYps
Copy link
Contributor Author

The script is a bash command, so it assumes you are using linux. It traverses all subdirectories from the working directory.

find "$(pwd)" -type f -name '*.bp' -path '*/Trees/*' | while IFS= read -r file; do
    sed -i '/^\s*ReclaimMassMax =/s/^\(\s*\)ReclaimMassMax =.*/\1ReclaimMassMax = 0,/' "$file"
done

Yes, please merge this in for testing

@Garanas Garanas merged commit 3c44f08 into deploy/fafdevelop Apr 17, 2024
3 checks passed
@Garanas Garanas deleted the tree-mass-reclaim branch April 17, 2024 13:40
lL1l1 added a commit that referenced this pull request Apr 19, 2024
Garanas added a commit that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants