New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platoon.lua annotation and warning fixes [lua/AI/aiutilities.lua] #6085
platoon.lua annotation and warning fixes [lua/AI/aiutilities.lua] #6085
Conversation
What do the question marks mean in the annotations there @clyfordv? |
7251883
to
ec4eef1
Compare
Optional parameters. Most of those marked as optional here are done so implicitly (read as: I found another piece of code somewhere that calls it with a bunch of |
This reverts commit ec4eef1.
Ah cheers. I'll take a look at this PR once I get home from work. |
Appreciate it. Happy to take any more questions or feedback, stylistic or mechanical. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues with this PR.
Similar to the other, we just need a snippet added.
It would be
/changelog/snippets/ai.6085.md
With just an entry of something like say
- (#6085) annotations of aiutilities.lua and logic fixes
Annotation and warning fixes for platoon.lua
files:
aiutilities.lua
focus:
$type|boolean
return values to$type|nil