Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platoon.lua annotation and warning fixes [lua/AI/aiutilities.lua] #6085

Conversation

clyfordv
Copy link
Contributor

Annotation and warning fixes for platoon.lua

files:
aiutilities.lua

focus:

  • annotation additions and fixes
  • convert $type|boolean return values to $type|nil
  • optional params

@clyfordv clyfordv changed the title platoon.lua annotation and warning fixes [aiutilities.lua] platoon.lua annotation and warning fixes [lua/AI/aiutilities.lua] Apr 15, 2024
@clyfordv clyfordv marked this pull request as draft April 15, 2024 15:56
@relent0r
Copy link
Contributor

What do the question marks mean in the annotations there @clyfordv?

@clyfordv clyfordv force-pushed the aiutilities.lua_annotations_Re-platoon.lua branch from 7251883 to ec4eef1 Compare April 15, 2024 20:57
@clyfordv
Copy link
Contributor Author

Optional parameters. Most of those marked as optional here are done so implicitly (read as: I found another piece of code somewhere that calls it with a bunch of nil values).

@relent0r
Copy link
Contributor

Optional parameters. Most of those marked as optional here are done so implicitly (read as: I found another piece of code somewhere that calls it with a bunch of nil values).

Ah cheers. I'll take a look at this PR once I get home from work.

@Hdt80bro Hdt80bro marked this pull request as ready for review April 15, 2024 22:25
@Hdt80bro Hdt80bro marked this pull request as draft April 15, 2024 22:27
@clyfordv
Copy link
Contributor Author

Appreciate it. Happy to take any more questions or feedback, stylistic or mechanical.

Copy link
Contributor

@relent0r relent0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with this PR.
Similar to the other, we just need a snippet added.

It would be
/changelog/snippets/ai.6085.md
With just an entry of something like say
- (#6085) annotations of aiutilities.lua and logic fixes

@relent0r relent0r marked this pull request as ready for review April 30, 2024 21:46
@relent0r relent0r merged commit 730e5c2 into FAForever:deploy/fafdevelop May 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants