Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platoon.lua annotation and warning fixes [auxiliary files] #6084

Merged
merged 17 commits into from May 1, 2024
Merged

platoon.lua annotation and warning fixes [auxiliary files] #6084

merged 17 commits into from May 1, 2024

Conversation

clyfordv
Copy link
Contributor

Modifies several auxiliary files referenced by platoon.lua to accomplish annotation and warning fixes.

focus:

  • Vector x/y/z fields and table.copy return type overload
  • AIBrain field annotations (incl CustomUnits table)
  • Unit field annotations
  • EngineerBuilder field annotations
  • @Class ThreatFunctions table annotation (for NavGenerator)
  • @Class Marker table annotation (position marker used by AI)
  • @Class ScoutLocation table annotation (scout position marker used by AI)
  • boolean->nil return type conversions where appropriate
  • marks params/return values as optional when appropriate
  • type corrections (ex: filename -> FileName)

@clyfordv clyfordv marked this pull request as draft April 15, 2024 15:57
@relent0r relent0r marked this pull request as ready for review May 1, 2024 09:54
@relent0r relent0r merged commit dea4a06 into FAForever:deploy/fafdevelop May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relent0r relent0r relent0r approved these changes

Assignees
No one assigned
Labels
type: intellisense
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clyfordv @relent0r @Hdt80bro