Clean up various blueprints #6081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How certain are we that these values are meaningless? |
|
All units I tested still functioned normally. According to the debug dialog that lets you change units in-game, these stats all default to 0 if their respective fields are not present. |
|
@Basilisk3 can you update the changelog to the snippet format? Then we can merge this in |
|
I added it in with the other two changes, is that correct? |
|
My mistake, I must have been confused! |
Garanas
added
the
area: unit-blueprint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
This PR attempts to remove the following fields from all blueprints:
BankingSlope = 0,MaxSteerForce = 0,MinSpeedPercent = 0,TurnRate = 0,Testing done on the proposed changes
I have not found any issues with the functionality of the units.
Checklist