Evaluate and rework the categories of UEF air units #5928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garanas
added
the
feature: target priorities
|
@relent0r / @maudlin27 please evaluate these category changes to make sure they do not mess with your AI 😃 ! |
|
Sorry I take back my previous comment. I'm checking with Sprouto to see if he agrees me. edit : No issue with this change. p.s did not know that particular bomber had a nuke category! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5919
Introduces the
WEAK...categories to various units. Also removes theNUKEcategory from the strategic bomber as it is... not a strategic unit.What I found interesting is that there's very little to no distinction between regular bombers and torpedo bombers. I was thinking of introducing aTORPEDOcategory to the torpedo bomber to make it more distinguishable. Now, of course - mods that are unmaintained will not follow this practice and therefore it would only apply to units we ship with FAForever directly.edit: apparently the
ANTINAVYcategory means 'something that fires torpedo's according to torpedo weapons and the categories of naval units, as seen in #5929. As a result, introducingTORPEDOis not necessary becauseANTINAVYessentially means that.