Feature/#2319 veto system: simple maplist popup

[K-ETFreeman]

"Maplist" button on the Play tab now summons popup with maplist instead of navigating to the vault.
This is "Simple" version of the popup, shows maps without duplicates, with grayscaling of map tiles

[Sheikah45]

This is a first pass review.

More generally there are lots of places where you set just a basic object in the controllers but this could lead to null pointer exceptions. It would be better to use a property to represent these fields like queue, pool, relevance. Then you can also use the binding and mapping on the properties so that the reactive changes are handled for you.

[codecov]

Codecov Report

Attention: Patch coverage is 5.44218% with 139 lines in your changes are missing coverage. Please review.

Project coverage is 58.19%. Comparing base (dd9ab2b) to head (12aaf8c).
Report is 2 commits behind head on develop.

❗ Current head 12aaf8c differs from pull request most recent head 331dfe0. Consider uploading reports for the commit 331dfe0 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #3151      +/-   ##
=============================================
- Coverage      58.83%   58.19%   -0.64%     
+ Complexity      3984     3951      -33     
=============================================
  Files            576      575       -1     
  Lines          19296    19279      -17     
  Branches        1022     1025       +3     
=============================================
- Hits           11353    11220     -133     
- Misses          7447     7569     +122     
+ Partials         496      490       -6     

Files	Coverage Δ
.../java/com/faforever/client/api/FafApiAccessor.java	90.12% <100.00%> (-0.07%)	⬇️
...ever/client/domain/api/MatchmakerQueueMapPool.java	100.00% <ø> (ø)
...main/java/com/faforever/client/map/MapService.java	69.65% <100.00%> (-2.19%)	⬇️
.../faforever/client/vault/VaultEntityController.java	39.76% <100.00%> (ø)
...a/com/faforever/client/map/MapVaultController.java	71.95% <0.00%> (+4.13%)	⬆️
...eammatchmaking/MatchmakingQueueItemController.java	77.64% <0.00%> (-4.29%)	⬇️
...ent/teammatchmaking/TeamMatchmakingController.java	79.10% <6.66%> (-5.85%)	⬇️
...mmatchmaking/TeamMatchmakingMapTileController.java	0.00% <0.00%> (ø)
...mmatchmaking/TeamMatchmakingMapListController.java	0.00% <0.00%> (ø)

... and 18 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ed832...331dfe0. Read the comment docs.

[K-ETFreeman]

Hi @Sheikah45 , some adjustments were made, i think it can be reviewed once more

[Sheikah45]

A few ways to use new method signatures to clean things up

[Sheikah45]

Also I would make an observable value queue.map(Queue::getLeaderboard) so that null exceptions with queues can be avoided